Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest upgrade 3.7.1 -> 6.2.5 #11759

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Pytest upgrade 3.7.1 -> 6.2.5 #11759

merged 13 commits into from
Jul 17, 2024

Conversation

thesujai
Copy link
Contributor

@thesujai thesujai commented Jan 20, 2024 •
edited
Loading

Summary

When i run test on files individually all are passing, but while running them at once it fails

References

Fixes #11728
…

Reviewer guidance

…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0b3.dev0+git.14.g144604ba-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0b3.dev0+git.14.g144604ba-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0b3.dev0+git.14.g144604ba.dmg
Android Package (APK) kolibri-0.17.0b3.dev0+git.14.g144604ba-0.1.3-debug.apk
TAR file kolibri-0.17.0b3.dev0+git.14.g144604ba.tar.gz
WHL file kolibri-0.17.0b3.dev0+git.14.g144604ba-py2.py3-none-any.whl

@rtibbles
Copy link
Member

This work should be targeted to develop and targeted there, as this version of pytest is not compatible with Python 2.7, which has been dropped in develop.

@rtibbles rtibbles self-assigned this Jan 20, 2024
@thesujai
Copy link
Contributor Author

@rtibbles okay i will change the target in final pr, but i am facing this issue
In develop branch only, after changing versions in requirements
Check that test_utils is failing when i ran all at once
Screenshot from 2024-01-20 22-11-01
But it passes when i run this individually
Screenshot from 2024-01-20 22-11-17

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: renderers HTML5 apps, videos, exercises, etc. DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend DEV: tools Internal tooling for development SIZE: medium labels Jan 20, 2024
@thesujai thesujai changed the base branch from release-v0.16.x to develop January 20, 2024 17:13
@thesujai thesujai changed the title change requirements Pytest upgrade 3.7.1 -> 6.2.5 Jan 20, 2024
@rtibbles
Copy link
Member

Interesting - there must be something else at play here. One possibility is a change in pytest that is causing state to be persisted between tests.

Seeing the traceback from the failed tests would help diagnose further!

Also it may be worth seeing if any of the other pytest plugins could be upgraded.

@rtibbles rtibbles removed DEV: renderers HTML5 apps, videos, exercises, etc. APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: medium labels Jan 20, 2024
@akolson akolson added the work-in-progress Not ready for review label May 9, 2024
@akolson
Copy link
Member

akolson commented May 9, 2024

In Hiatus until @rtibbles has the bandwidth to pick it up!

@jredrejo
Copy link
Member

jredrejo commented Jun 17, 2024 •
edited
Loading

@rtibbles I think we should move this from the hiatus status, after 2.7 support has been finished, and specially if new versions of django are been used (as a reference, KDP has been using 6.2.1 since September 2022)

@rtibbles
Copy link
Member

Yes, I have the overall issue for upgrading to support Python 3.12, which this is a prerequisite for.

@rtibbles rtibbles force-pushed the pytest-upgrade-6.2.5 branch 3 times, most recently from 6a50ac2 to 866b391 Compare July 1, 2024 19:00
@rtibbles rtibbles changed the base branch from develop to release-v0.17.x July 12, 2024 16:18
@rtibbles rtibbles marked this pull request as ready for review July 17, 2024 19:05
@rtibbles rtibbles added TODO: needs review Waiting for review and removed work-in-progress Not ready for review labels Jul 17, 2024
rtibbles
rtibbles approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here only affect test files and related github actions/configuration. I have asked @marcellamaki to confirm as I have done a significant chunk of the work here too.

@rtibbles rtibbles merged commit 4608263 into learningequality:release-v0.17.x Jul 17, 2024
33 checks passed
@rtibbles rtibbles mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees

@rtibbles rtibbles

Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment DEV: tools Internal tooling for development SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pytest to 6.2.5
4 participants
@thesujai @rtibbles @akolson @jredrejo